Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default image in the cluster-autoscaler addon #1552

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Default image in the cluster-autoscaler addon #1552

merged 1 commit into from
Sep 29, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Sep 29, 2021

What this PR does / why we need it:

Currently, the cluster-autoscaler addon cannot be used as an embedded addon because we don't default the image/version. Instead, users still have to copy the addon to their addons directory and then manually modify the image.

The embedded addons are supposed to be used without having to copy and modify them, and this PR modifies the cluster-autoscaler addon to support this use case.

There are two changes in this PR:

  • The image is now defaulted depending on the Kubernetes version of the cluster
  • The image can be overridden via addon parameters:
...
addons:
  enable: true
  path: "./addons"
  addons:
  - name: cluster-autoscaler
    params:
      CLUSTER_AUTOSCALER_IMAGE: "k8s.gcr.io/autoscaling/cluster-autoscaler:v1.21.0"

Does this PR introduce a user-facing change?:

Default image in the cluster-autoscaler addon and allow the image to be overridden using addon parameters

@xmudrii
Default image in the cluster-autoscaler addon
0bf0f48 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2021
@xmudrii
Copy link
Member Author

xmudrii commented Sep 29, 2021

/cherrypick release/v1.3

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.3 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xrstf
xrstf approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d04e3eb929e441b546c54ec03ec998361a67f88

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 84f069f into master Sep 29, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Sep 29, 2021
@kubermatic-bot kubermatic-bot deleted the fix-autoscaler-version branch September 29, 2021 10:06
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #1553

In response to this:

/cherrypick release/v1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Sep 29, 2021
Merged
@xmudrii xmudrii mentioned this pull request Sep 30, 2021
Closed
@xmudrii xmudrii mentioned this pull request Oct 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @xrstf